#name raises an exception with unloaded

ruby · Jun 14, 2023 · af6c2e6 · af6c2e6
1 parent 602a411
commit af6c2e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/ext/openssl/ossl_provider.c b/ext/openssl/ossl_provider.c
@@ -149,20 +149,16 @@ ossl_provider_unload(VALUE self)
  * call-seq:
  *    provider.name -> string
  *
- * Get the name of the provider.
+ * Get the name of this provider.
  *
- * if this provider is already unloaded, it returns nil
- *    l = OpenSSL::Provider.load("legacy")
- *    l.name #=> "legacy"
- *    l.unload
- *    l.name #=> nil
+ * if this provider is already unloaded, it raises OpenSSL::Provider::ProviderError
  */
 static VALUE
 ossl_provider_get_name(VALUE self)
 {
     OSSL_PROVIDER *prov;
-    if (RTYPEDDATA_DATA(self) == NULL ) {
-        return Qnil;
+    if (RTYPEDDATA_DATA(self) == NULL) {
+        ossl_raise(eProviderError, "Provider already unloaded.");
     }
     GetProvider(self, prov);
 

diff --git a/test/openssl/test_provider.rb b/test/openssl/test_provider.rb
@@ -23,10 +23,11 @@ def test_openssl_provider_names
     end;
   end
 
-  def test_openssl_provider_unload_twice
+  def test_unloaded_openssl_provider
     with_openssl <<-'end;'
       default_provider = OpenSSL::Provider.load("default")
       assert_equal(true, default_provider.unload)
+      assert_raise(OpenSSL::Provider::ProviderError) { default_provider.name }
       assert_raise(OpenSSL::Provider::ProviderError) { default_provider.unload }
     end;
   end