Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem ship. #61

Closed
3 tasks done
hsbt opened this issue Jul 10, 2016 · 30 comments
Closed
3 tasks done

Gem ship. #61

hsbt opened this issue Jul 10, 2016 · 30 comments

Comments

@hsbt
Copy link
Member

hsbt commented Jul 10, 2016

I found some blocker for openssl gem release.

@rhenium @zzak If you have some blocker, Please note this issue. I will try to solve it.

@hsbt
Copy link
Member Author

hsbt commented Jul 10, 2016

I send transfer offer to openssl owner.

@rhenium
Copy link
Member

rhenium commented Jul 10, 2016

I contacted the current owner at mbailey/openssl#1 and @mbailey agreed with releasing the gem namespace.

@hsbt
Copy link
Member Author

hsbt commented Jul 10, 2016

oops. Should I continue to transfer negotiation instead of you?

And I sometimes request to remove stdlib protection to rubygems admins. see. rubygems/rubygems.org#1273

@hsbt
Copy link
Member Author

hsbt commented Jul 10, 2016

commented mbailey/openssl#1 (comment)

@hsbt
Copy link
Member Author

hsbt commented Jul 13, 2016

@zzak
Copy link
Member

zzak commented Jul 13, 2016

I guess we still need to decide a version number?

@hsbt
Copy link
Member Author

hsbt commented Jul 28, 2016

@rhenium I've been promoted openssl owner by rubygems admins. Can you give your mail address on rubygems?

@rhenium
Copy link
Member

rhenium commented Jul 28, 2016

@hsbt Thank you always! My email is k(at)rhe.jp.

@hsbt
Copy link
Member Author

hsbt commented Jul 28, 2016

@rhenium I added owner grant to you. If you are ready to ship openssl gem, I'm going to request to remove openssl from rubygems blacklist.

@rhenium
Copy link
Member

rhenium commented Jul 28, 2016

@hsbt Thanks!

It looks like openssl is already excluded from the list, at least in the source repository. rubygems/rubygems.org@6e74bd9

I think we can release now if only we decide the version number.

@zzak
Copy link
Member

zzak commented Jul 28, 2016

@hsbt @rhenium お疲れさまです! I will review #59 and commit my changes to the documentation.

Regarding the NEWS, as of 1b8bcdb the organization is:

  • Compatibility
  • Updates since 2.3 (in order of class)

However, there is some duplication between the updates and compatibility list.

I will review this too, but first I think we could split it up similar to Rails release notes as such:

  • Compatibility notes (with regards to OpenSSL versions)
  • Supported platforms (with current release)
  • Changes in current release

Changes would include the following:

  • Notable changes (such as breaking api, or additions, features, etc)
  • Removals (Already deprecated features that were removed)
  • Deprecations (Stuff to be removed next release)

One other idea is after the release is made, we should consider moving the NEWS document like we do with Ruby, i.e.: docs/NEWS-2.4.0

Thanks for taking the time to work on this and prepare the release!

I will submit my thoughts in the form of a patch :)

@rhenium
Copy link
Member

rhenium commented Jul 29, 2016

@zzak Thanks! That's a great help.

One other idea is after the release is made, we should consider moving the NEWS document like we do with Ruby, i.e.: docs/NEWS-2.4.0

I think we can just append on top, each release note would be smaller than Ruby. Maybe I should have named it History.

@zzak
Copy link
Member

zzak commented Aug 1, 2016

Append is also fine! Let's go with History.

@zzak
Copy link
Member

zzak commented Aug 9, 2016

@rhenium @hsbt I sent a PR with my changes, please check it when you're ready

I think we can also close #54 once this is done, thanks!!

@rhenium
Copy link
Member

rhenium commented Aug 9, 2016

@zzak Thank you! It looks much nicer! Do you have suggestions on changes in README.md and CONTRIBURING.md?

@zzak
Copy link
Member

zzak commented Aug 9, 2016

@rhenium Thanks, I will review.

@hsbt
Copy link
Member Author

hsbt commented Aug 13, 2016

OpenSSL::VERSION already retunes "1.1.0". We should use 2.0.0 when releasing openssl gem.

@rhenium
Copy link
Member

rhenium commented Aug 26, 2016

OpenSSL 1.1.0 was just released today, and Ruby/OpenSSL looks working fine with it: https://travis-ci.org/ruby/openssl/builds/155282416

Is there still a blocker for the release?

@hsbt
Copy link
Member Author

hsbt commented Aug 26, 2016

Is there still a blocker for the release?

There is no blocker for me :octocat:

@zzak
Copy link
Member

zzak commented Aug 28, 2016

I have no blockers, version 2.0.0 sounds fine.

Let's yank the current gems from rubygems.org and cut a pre-release?

@rhenium
Copy link
Member

rhenium commented Aug 28, 2016

Let's yank the current gems from rubygems.org and cut a pre-release?

I think so! Can I do that?

@zzak
Copy link
Member

zzak commented Aug 28, 2016

@rhenium Yes, if you are authenticated on rubygems.org, via the gem command you can yank the old versions with:

gem yank openssl -v '0.2.0'
gem yank openssl -v '0.1.0'

And to publish (after updating version.rb):

gem build openssl.gemspec
gem push openss-2.0.0.beta1.gem

For example if you wanted to choose "beta1" as the first pre-release.

@rhenium
Copy link
Member

rhenium commented Aug 29, 2016

Just pushed openssl-2.0.0.beta1: https://rubygems.org/gems/openssl

@rhenium
Copy link
Member

rhenium commented Aug 29, 2016

Imported to trunk at: ruby/ruby@c9dc016

@zzak
Copy link
Member

zzak commented Aug 29, 2016

@rhenium Ah great!

Btw, I think two things are missing in History from #18, that is ALPN and ECDH callback support.

We can add it to the news in the next beta/rc?

edit: also, I want to "linkify" the History.md so we can click through the tickets/PRs from there

@zzak
Copy link
Member

zzak commented Aug 29, 2016

Linkify in #69

@zzak
Copy link
Member

zzak commented Aug 29, 2016

@tenderlove BTW bro, the tmp_ecdh_callback stuff was removed in favor of ecdh_curves: https://github.com/ruby/openssl/blob/v2.0.0.beta.1/History.md#deprecations

zzak pushed a commit that referenced this issue Aug 29, 2016
@rhenium
Copy link
Member

rhenium commented Aug 29, 2016

@zzak ALPN and ECDH callback are part of Ruby 2.3 (though they aren't in doc/NEWS-2.3.0).

@zzak
Copy link
Member

zzak commented Aug 29, 2016

@rhenium Ahh, ok! I will revert 59b22d4 then.

@hsbt
Copy link
Member Author

hsbt commented Sep 1, 2016

Gem ship is done. ref. https://rubygems.org/gems/openssl/versions/2.0.0.beta.1

@hsbt hsbt closed this as completed Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants