x509name: Correct inverted return for #eql? #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 34e7fe3 introduced a regression that inverted the return value of OpenSSL::X509::Name#eql?; this commit fixes Bug #13170 and restores the original semantics. Reference: https://bugs.ruby-lang.org/issues/13170
|
Thank you for reporting. I commited an identical patch just a few days ago: 4ccaf25 |
shawnferry
pushed a commit
to shawnferry/puppet
that referenced
this pull request
Jun 30, 2017
Commit [34e7fe3][regression] of ruby/openssl negated the behavior of `OpenSSL::X509::Name#eql?`, which broke our spec tests. In contrast `OpenSSL::X509::Name#== continues to work as expected and the use of `#eql?` is uncommon; this commit bypasses the issue entirely. [regression]: ruby/openssl@34e7fe3#diff-8621484175a9fd7841e498512cb2944f [bugfix]: ruby/openssl#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 34e7fe3 introduced a regression that inverted the return value
of OpenSSL::X509::Name#eql?; this commit fixes Bug #13170 and restores the
original semantics.
Reference: https://bugs.ruby-lang.org/issues/13170