Add fips_mode_get to return fips_mode #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
reviewed
Jun 9, 2017
test/test_fips.rb
Outdated
| OpenSSL.fips_mode == true | ||
| OpenSSL.fips_mode = false | ||
| OpenSSL.fips_mode == false | ||
| end |
There was a problem hiding this comment.
This is not testing. Also, the mode can not necessarily be switched at runtime. I think all we can do here is:
assert OpenSSL.fips_mode == true || OpenSSL.fips_mode == false,
".fips_mode returns a boolean value"
There was a problem hiding this comment.
I'll update, but when can the mode not be changed at runtime? Tested locally with fips enabled by default.
There was a problem hiding this comment.
Ah, nevermind, my memory tricked me.
rhenium
reviewed
Jun 9, 2017
test/test_fips.rb
Outdated
| assert OpenSSL.fips_mode == true, ".fips_mode returns true when .fips_mode=true" | ||
|
|
||
| OpenSSL.fips_mode = false | ||
| assert OpenSSL.fips_mode == false, ".fips_mode returns false when .fips_mode=false" |
There was a problem hiding this comment.
Ugh, rough start of the day :)
|
Thanks, this now looks good to me. Can you squash them into one commit? |
cwjenkins
force-pushed
the
feature/add_fips_mode_get
branch
from
0a02925
to
2958067
Compare
|
Yeppers, squashed. Thanks! Now off to bundler :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL::OPENSSL_FIPScauses confusion as the doc states it returns a boolean based on if FIPS is 'enabled' which isn't true. It is dependent on whether the openssl installed was built with FOM (fips object module). If it was then it will always returns true (even whenfips_mode = false), thus it is more accurate to say FIPS-capable.Adding
OpenSSL.fips_modeto return whether or not fips_mode is currently set. This allows for better handling around fips mode.