Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509*: implement == #161

Merged
merged 6 commits into from Oct 22, 2017
Merged

x509*: implement == #161

merged 6 commits into from Oct 22, 2017

Conversation

rhenium
Copy link
Member

@rhenium rhenium commented Oct 19, 2017

This pull request adds:

  • OpenSSL::X509::Extension#==
  • OpenSSL::X509::Attribute#==
  • OpenSSL::X509::Certificate#==
  • OpenSSL::X509::CRL#==
  • OpenSSL::X509::Revoked#==
  • OpenSSL::X509::Revoked#to_der
  • OpenSSL::X509::Request#==

#158 can be closed when this is merged.

cc: @mcr

mcr
mcr reviewed Oct 20, 2017
View reviewed changes
Copy link
Contributor

@mcr mcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, exactly what I needed!

@rhenium rhenium merged commit d834e86 into ruby:master Oct 22, 2017
@rhenium rhenium mentioned this pull request Oct 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcr mcr mcr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhenium @mcr