Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review OpenSSL::X509::Store #392

Merged
merged 7 commits into from
Aug 21, 2020
Merged

Review OpenSSL::X509::Store #392

merged 7 commits into from
Aug 21, 2020

Commits on Aug 12, 2020

  1. x509store: let X509::Store#add_file raise TypeError if nil is given 

    Undo special treatment of nil and simply pass the value to
StringValueCStr().

nil was never a valid argument for the method; OpenSSL::X509::StoreError
with an unhelpful error message "system lib" was raised in that case.
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    fb2fcbb View commit details
    Browse the repository at this point in the history

  2. x509store: emit warning if arguments are given to X509::Store.new 

    Anything passed to OpenSSL::X509::Store.new was always ignored. Let's
emit an explicit warning to not confuse users.
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    d173700 View commit details
    Browse the repository at this point in the history

  3. x509store: refactor X509::StoreContext#chain 

    Use ossl_x509_sk2ary() to create an array of OpenSSL::X509::Certificate
from STACK_OF(X509).
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    fa1da69 View commit details
    Browse the repository at this point in the history

  4. x509store: avoid ossl_raise() calls with NULL message 

    Use the OpenSSL function name that caused the error to generate a better
error message.
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    b31809b View commit details
    Browse the repository at this point in the history

  5. x509store: update rdoc for X509::Store and X509::StoreContext 

    Add more details about each method, and add reference to OpenSSL man
pages.
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    02b6f82 View commit details
    Browse the repository at this point in the history

  6. test/openssl/test_x509store: break up test_verify 

    The test case is huge and too complex. Break it up into separate test
cases for better documentation.
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    61012df View commit details
    Browse the repository at this point in the history

  7. test/openssl/test_x509store: tidy up tests for X509::Store#add_cert 

    Rename the test case to test_add_cert_duplicate to clarify what it is
actually testing.
    @rhenium
    rhenium committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    4cc3c41 View commit details
    Browse the repository at this point in the history