Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example to OpenSSL::KDF.hkdf method #447

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Add example to OpenSSL::KDF.hkdf method #447

merged 2 commits into from
Jun 27, 2021

Conversation

unasuke
Copy link
Contributor

@unasuke unasuke commented Jun 26, 2021

I tried to use OpenSSL::KDF.hkdf to confirm RFC 5869, but I struggled there is no example code.

So I wrote an example.

rhenium
rhenium reviewed Jun 26, 2021
View reviewed changes
Copy link
Member

@rhenium rhenium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I think that would be helpful. Thank you!

ext/openssl/ossl_kdf.c Outdated Show resolved Hide resolved
@unasuke @rhenium
Update ext/openssl/ossl_kdf.c
0c8c999 
Co-authored-by: Kazuki Yamaguchi <k@rhe.jp>
@rhenium rhenium merged commit ec14a87 into ruby:master Jun 27, 2021
@rhenium
Copy link
Member

rhenium commented Jun 27, 2021

Thank you!

@unasuke unasuke deleted the kdf_hkdf_example branch June 27, 2021 07:38
rhenium pushed a commit to rhenium/ruby that referenced this pull request Jul 18, 2021
@unasuke @rhenium
[ruby/openssl] Add example to OpenSSL::KDF.hkdf method (ruby/openssl#447
11651ab 
)

The values from RFC 5869
https://datatracker.ietf.org/doc/html/rfc5869#appendix-A.1

ruby/openssl@ec14a87f4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhenium rhenium rhenium left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unasuke @rhenium