Use SHA256 instead of SHA1 where needed in tests. #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systems such as RHEL 9 are moving away from SHA1 disabling it completely in default configuration.
|
I decided to redo the change completely instead of trying to fix I had done in #511 . |
|
Thank you! |
hsbt
pushed a commit
to ruby/spec
that referenced
this pull request
Jan 5, 2023
Systems such as CentOS 9 / RHEL 9 are moving away from SHA1 disabling it by default via a system-wide crypto policy. This replaces SHA1 with SHA256 in similar way as [[1]]. [1]: ruby/openssl#554
seven1m
pushed a commit
to seven1m/ruby_spec
that referenced
this pull request
Sep 2, 2023
Systems such as CentOS 9 / RHEL 9 are moving away from SHA1 disabling it by default via a system-wide crypto policy. This replaces SHA1 with SHA256 in similar way as [[1]]. [1]: ruby/openssl#554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systems such as RHEL 9 are moving away from SHA1
disabling it completely in default configuration.
This is a follow-up PR after #507. This PR has the goal of fixing the rest of the test failures [0] present on systems that disable SHA1, like RHEL 9 and Centos 9 stream, by default via a system-wide crypto policy.
Tests pass locally with these changes.
[0] https://gist.github.com/jackorp/bb6e3ff2cfd339f2f65afcdc5c9e4070
This supersedes #511