Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefine OpenSSL::SSL for no socket platforms #558

Merged
merged 3 commits into from Dec 22, 2022

Commits on Dec 22, 2022

  1. Copy the full SHA
    a3d230d View commit details
    Browse the repository at this point in the history
  2. ssl: remove OpenSSL::ExtConfig

    This module was introduced in 2015 for internal use within this library.
    Neither of the two constants in it is used anymore. I don't think we
    will be adding a new constant in the foreseeable future, either.
    
    OPENSSL_NO_SOCK is unused since commit 998d667 (r55191).
    HAVE_TLSEXT_HOST_NAME is unused since commit 4eb4b32.
    rhenium committed Dec 22, 2022
    Copy the full SHA
    eed3894 View commit details
    Browse the repository at this point in the history
  3. Undefine OpenSSL::SSL for no socket platforms

    This fixes a linkage error about `ossl_ssl_type` on platforms which do
    not have socket, like WASI.
    
    Even before this patch, some items are disabled under `OPENSSL_NO_SOCK` since
    ruby/ruby@ee22fad
    However, due to some new use of OpenSSL::SSL::Socket over the past few years,
    the build under `OPENSSL_NO_SOCK` had been broken.
    
    This patch guards whole `OpenSSL::SSL` items by `OPENSSL_NO_SOCK`.
    
    [ky: adjusted to apply on top of my previous commit that removed the
    OpenSSL::ExtConfig, and added a guard to lib/openssl/ssl.rb.]
    kateinoigakukun authored and rhenium committed Dec 22, 2022
    Copy the full SHA
    b0cfac6 View commit details
    Browse the repository at this point in the history