Fixes OPENSSL_LIBRARY_VERSION description on documentation #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
reviewed
Nov 23, 2022
ext/openssl/ossl.c
Outdated
| #if !defined(LIBRESSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER >= 0x10100000 | ||
| rb_define_const(mOSSL, "OPENSSL_LIBRARY_VERSION", rb_str_new2(OpenSSL_version(OPENSSL_VERSION))); | ||
| const char *ssl_version = OpenSSL_version(OPENSSL_VERSION); |
There was a problem hiding this comment.
openssl gem supports older Ruby versions, so we can't use C99 feature (declaration after statements) yet.
Would rdoc be happy if we simply move the doc comment inside the #if block?
There was a problem hiding this comment.
Thanks!
Did what you suggested.
|
Thank you! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 13, 2022
documentation (ruby/openssl#559) Adds back missing constant description on the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back missing constant description on the documentation
Currently:
After fix:
