Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Rename the key name "foo_bar" (underscore) to "foo-bar" (hyphen). #634

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Jun 1, 2023

This PR is for refactoring. Sorry, I made this inconsistency for the YAML key names by the commit 18b0172. I want to fix this issue before modifying the GitHub Actions YAML file in addition.


GitHub Action YAML config file's key names are a style with the "foo-bar" (hyphen). This commit is to rename the key names with "foo_bar" (underscore) to "foo-bar" (hyphen) for consistency.

  • Replaced "fips_enabled" with "fips-enabled".
  • Replaced "append_configure" with "append-configure".
  • Replaced "name_extra" with "name-extra".

GitHub Action YAML config file's key names are a style with the "foo-bar"
(hyphen). This commit is to rename the key names with "foo_bar" (underscore) to
"foo-bar" (hyphen) for consistency.

* Replaced "fips_enabled" with "fips-enabled".
* Replaced "append_configure" with "append-configure".
* Replaced "name_extra" with "name-extra".
@junaruga
Copy link
Member Author

junaruga commented Jun 1, 2023

I tested the necessary key names were replaced by the commands below.

$ grep fips_enabled .github/workflows/test.yml
$ grep append_configure .github/workflows/test.yml
$ grep name_extra .github/workflows/test.yml

@junaruga junaruga merged commit 35456a3 into ruby:master Jun 2, 2023
42 checks passed
@junaruga junaruga deleted the wip/ci-rafactor-key-names branch June 2, 2023 20:56
@junaruga
Copy link
Member Author

junaruga commented Jun 2, 2023

Merged. I hope you guys like this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant