Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More on tutorial #22

Merged
merged 1 commit into from
Apr 15, 2021
Merged

More on tutorial #22

merged 1 commit into from
Apr 15, 2021

Conversation

BurdetteLamar
Copy link
Member

  • Adds argument abbreviation in option_params.rdoc.
  • Adds entire Argument Values section to tutorial.rdoc.

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Apr 14, 2021
olleolleolle
olleolleolle reviewed Apr 15, 2021
View reviewed changes
doc/optparse/tutorial.rdoc
===== Explicit Values in Array

You can specify explicit argument values in an array of strings.
The argument value must be one of those strings, or an unambiguous abbreviation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I just learned something. I was missing a word like explicitly permitted or the like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was how I came to misread it: I'd missed that the setting was an "allowed values" list.

olleolleolle
olleolleolle approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ace. Thanks for the stream of improvement.

@BurdetteLamar BurdetteLamar merged commit 9c5b3f2 into ruby:master Apr 15, 2021
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 28, 2021
@BurdetteLamar @hsbt
[ruby/optparse] More on tutorial (ruby/optparse#22)
98ccb49 
    Adds argument abbreviation in option_params.rdoc.
    Adds entire Argument Values section to tutorial.rdoc.

ruby/optparse@9c5b3f244b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@nobu nobu Awaiting requested review from nobu

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BurdetteLamar @olleolleolle