Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More on tutorial #9

Merged
merged 4 commits into from Apr 6, 2021
Merged

More on tutorial #9

merged 4 commits into from Apr 6, 2021

Conversation

BurdetteLamar
Copy link
Member

Option arguments: none, required, optional.

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Mar 30, 2021
@BurdetteLamar
Copy link
Member Author

The second commit corrects several errors.

@BurdetteLamar BurdetteLamar marked this pull request as draft April 1, 2021 15:58
@BurdetteLamar
Copy link
Member Author

Marking as draft, to reorg files to accommodate future work.

@BurdetteLamar BurdetteLamar marked this pull request as ready for review April 1, 2021 16:07
@BurdetteLamar
Copy link
Member Author

Now ready for review.

@BurdetteLamar
Copy link
Member Author

@nobu, is there a place where the doc for merged (but not yet released) code is built out?

@BurdetteLamar
Copy link
Member Author

@nobu, will you be reviewing this? If not, can you suggest a different reviewer? Or maybe we just don't want the tutorial?

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thank you, @BurdetteLamar for upgrading these documentation files. The grammar and the inclusion of "what happens when not supplying required arguments" 💯.

@BurdetteLamar
Copy link
Member Author

@nobu, is there a place where the doc for merged (but not yet released) code is built out?

@olleolleolle, do you know about where the doc is built?

@olleolleolle
Copy link
Contributor

@BurdetteLamar Not yet!

@BurdetteLamar
Copy link
Member Author

@nobu and @hsbt, if no objection, I'll merge this. It's doc-only, and does not modify existing code or doc.

@BurdetteLamar BurdetteLamar merged commit 84dfd92 into ruby:master Apr 6, 2021
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 28, 2021
* More on tutorial

* More on tutorial

* More on tutorial

* More on tutorial: clearer example output

ruby/optparse@84dfd92d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

None yet

3 participants