Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alias of load to unsafe_load #539

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Remove alias of load to unsafe_load #539

merged 1 commit into from
Jan 20, 2022

Conversation

miry
Copy link
Contributor

@miry miry commented Jan 19, 2022

There are method Psych.load and alias load to unsafe_load exists in same time.

According the code load is now decorate safe_load.

Rdoc generates docs base on alias: https://docs.ruby-lang.org/en/3.1/Psych.html#method-c-load

image

The same versions exists in ruby https://github.com/ruby/ruby/blob/fb4df44d1670e9d25aef6b235a7281199a177edb/ext/psych/lib/psych.rb#L276

I assume the changes should first made here. Let me know if it is correct.

@hsbt hsbt merged commit c40ce47 into ruby:master Jan 20, 2022
@hsbt
Copy link
Member

hsbt commented Jan 20, 2022

@miry Good catch. Thanks.

@tenderlove this alias is needless after replacing safe_load by default. If you have any concern, Please ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants