Remove bundled libyaml #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
remove-bundled-libyaml
branch
from
67b2219
to
36242ed
Compare
hsbt
force-pushed
the
remove-bundled-libyaml
branch
from
82b5283
to
8734035
Compare
.github/workflows/windows.yml
Outdated
| - name: Run test | ||
| run: rake | ||
| k |
There was a problem hiding this comment.
Suggested change
| k |
Typo?
hsbt
force-pushed
the
remove-bundled-libyaml
branch
from
e430a38
to
5886bae
Compare
hsbt
force-pushed
the
remove-bundled-libyaml
branch
from
fc67210
to
aca703c
Compare
|
I only now realized there is already a PR for this on top of the original #535 - I would like to suggest not to merge this because there is a bug in the libyaml packaged in the currently used Ubuntu/Debian versions, and if I understand correctly merging this would render the fix (of not installing libyaml-dev) no longer working, see also rbenv/ruby-build#1950 (correct me if I'm wrong, maybe I'm also misunderstanding something about this or how psych and Ruby work together here) |
nobu
reviewed
Mar 18, 2022
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
nobu
reviewed
Mar 19, 2022
hsbt
force-pushed
the
remove-bundled-libyaml
branch
from
a595e99
to
3157783
Compare
hsbt
force-pushed
the
remove-bundled-libyaml
branch
from
3157783
to
fe57dfe
Compare
hsbt
added a commit
to ruby/ruby-ci-image
that referenced
this pull request
Mar 23, 2022
ima1zumi
added a commit
to ima1zumi/rubyhackchallenge
that referenced
this pull request
Aug 14, 2022
libyaml-dev is no longer bundled. ref: ruby/psych#541
ima1zumi
added a commit
to ima1zumi/rubyhackchallenge
that referenced
this pull request
Aug 14, 2022
libyaml-dev is no longer bundled. ref: ruby/psych#541
mame
pushed a commit
to ko1/rubyhackchallenge
that referenced
this pull request
Aug 14, 2022
libyaml-dev is no longer bundled. ref: ruby/psych#541
2 tasks
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Dec 12, 2022
Needed to be able to install psych >=5. Need to do it before setup-ruby runs as that runs `bundle install`. Related to: - ruby/psych#541 - ruby/setup-ruby#409 - actions/runner-images#6725 Yes, libyaml-dev will be added to GitHub runner images (this week they say) but opening this PR just in case anyone encounters failing builds. I don't think it hurts having this in the repo even after libyaml-dev have been added to the images. Added some blank lines to make the workflow easier to read.
jkowens
pushed a commit
to sinatra/sinatra
that referenced
this pull request
Dec 15, 2022
Needed to be able to install psych >=5. Need to do it before setup-ruby runs as that runs `bundle install`. Related to: - ruby/psych#541 - ruby/setup-ruby#409 - actions/runner-images#6725 Yes, libyaml-dev will be added to GitHub runner images (this week they say) but opening this PR just in case anyone encounters failing builds. I don't think it hurts having this in the repo even after libyaml-dev have been added to the images. Added some blank lines to make the workflow easier to read.
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535