New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rake 11.0.0 crashes with "cannot load such file -- rake/ext/fixnum" #114
Comments
Same error with Ruby 2.3.0 and Ruby on Rails
|
Same here when trying to capify a Sinatra project bundle exec cap install |
Same here when I working on my rails3 project,
but after run rvm remove 1.9.3, rvm install 1.9.3, and bundle install
|
Looks like the file |
I feel like it goes without saying, but such an important gem should probably be tested more throughly before being released!?
|
Hi All. Thank you for your report. I added missing file to gem package and released 11.0.1. Please try this 🙇 |
Now it's broken some different way.
|
@ioquatix It's rspec issue. I removed last_comment at Rake 11 @Sega100500 It's not rake issue. You need to learn bundler environment. |
Thanks for fixing this! I've confirmed that this issue is solved with |
Thanks for the update @hsbt, it's working for me minus the Made a PR for the |
@hsbt |
Yes it may be a rspec issue. How many people is this going to break for? |
Can I ask why last_comment was removed without a deprecation notice? As far as I can tell, last_comment was a public method. This also breaks YARD. Multiple widely used gems are broken by this change. Was there a reason to break this? |
@hsbt actually, my question about why it was removed wasn't really about the transition plan, but rather, why it was necessary to remove this in the first place? I understand that it's a superfluous method and was around for backward compatibility (though poorly documented as such), but the implementation was a single line of code. I guess my question is this: Was having this alias around an actual maintenance burden? Was it causing some technical debt? Did it create any bugs? If none of these things are true, it's worth noting that removing this method has now created more technical debt, maintenance burdens, and bugs in other projects than simply keeping it around has. I would recommend reverting the removal of the |
Some discussion regarding the change: ruby/rake#114 (comment)
Tried the latest rake on a Rails and Sinatra project and I'm getting this result
The text was updated successfully, but these errors were encountered: