Set up handling test failure #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable `fail-fast` * Allow fails on `master-nightly-focal` if it’s not PR
k0kubun
added a commit
to ruby/ruby
that referenced
this pull request
Sep 23, 2023
For some reason, it's been failing only on YJIT, but apparently it's reproducible on the interpreter as well. So it's not related to YJIT. rbs marked rbs tests on Ruby master as allow_failures ruby/rbs#1536, so it's known to not work on Ruby master. We should revert this once we fix the flaky test failure on Ruby master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail-fastto continueRequiredtests even after fails onmaster-nightly-focalmaster-nightly-focalif it’s not PR