Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop exiting with error when syntax error detected during validation #1603

Merged
merged 1 commit into from Nov 9, 2023
Merged

Stop exiting with error when syntax error detected during validation #1603

merged 1 commit into from Nov 9, 2023

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Nov 9, 2023

This PR stops exiting with error when syntax error is detected.

When the new syntax validation detects an error:

  1. It prints the errors the end of validation command
  2. It exits with 0 to avoid rbs validate command failing
  3. Pass --exit-error-on-syntax-error to exit(1)

Related to: #1566

@soutaro soutaro added this to the RBS 3.3 milestone Nov 9, 2023
@soutaro soutaro added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit b9c033a Nov 9, 2023
23 checks passed
@soutaro soutaro deleted the non-error-exit-on-syntax-error branch November 9, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soutaro