Fix failing stdlib_test with Ruby 3 keyword argument #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
commented
Jan 3, 2020
| @@ -3,6 +3,8 @@ | |||
| require "ruby/signature/test" | |||
| require "logger" | |||
|
|
|||
| return unless Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.0') | |||
There was a problem hiding this comment.
It skips test for Ruby::Signature::Test:Hook if the Ruby runtime version is less than 2.7.
We also use ruby2_keywords gem to apply the polyfill instead of the skipping, but it needs ruby/ruby2_keywords#3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today removing Ruby 2 keyword argument was committed to the master branch of Ruby.
ruby/ruby@beae6cb
So the stdlib test fails with the master branch.
This pull request fixes the failing.
The original idea is from @mame. Thanks!