Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pathame() argument type more accurate #1681

Merged
merged 2 commits into from Dec 19, 2023
Merged

Make Pathame() argument type more accurate #1681

merged 2 commits into from Dec 19, 2023

Conversation

KitaitiMakoto
Copy link
Contributor

Currently, Pathname() argument's type is declared as string | Pathname but actually it accepts objects which responds to #to_str.

I agree for this patch to be distributed under RBS's license.

@soutaro soutaro added this to the RBS 3.4 milestone Dec 18, 2023
@soutaro soutaro added this pull request to the merge queue Dec 19, 2023
Merged via the queue into ruby:master with commit b2689e7 Dec 19, 2023
23 checks passed
@KitaitiMakoto
Copy link
Contributor Author

Thanks!

@KitaitiMakoto KitaitiMakoto deleted the pathname-arg branch December 19, 2023 06:59
soutaro added a commit that referenced this pull request Dec 20, 2023
@soutaro
Revert "Merge pull request #1681 from KitaitiMakoto/pathname-arg"
fd5853a 
This reverts commit b2689e7, reversing
changes made to 89e89f8.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.4.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KitaitiMakoto @soutaro