Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String gsub! #1768

Merged
merged 3 commits into from Mar 22, 2024
Merged

String gsub! #1768

merged 3 commits into from Mar 22, 2024

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Mar 18, 2024

I found next pattern.

'a'.gsub!(/b/).each { }
#=> nil

And I also fixed the cause of the test_gsub! being omit.
Then I have also added more test cases.

@ksss
There is a possibility that nil is returned.
4a4386c 
```rb
'a'.gsub!(/b/).each { }
```
@ksss
Copy link
Collaborator Author

ksss commented Mar 18, 2024

Oh, it needs a few more revisions.

@ksss
Copy link
Collaborator Author

ksss commented Mar 19, 2024

Ready to merge.

soutaro
soutaro approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@soutaro soutaro added this pull request to the merge queue Mar 22, 2024
@soutaro soutaro added this to the RBS 3.5 milestone Mar 22, 2024
Merged via the queue into ruby:master with commit 50c9ecd Mar 22, 2024
17 checks passed
@ksss ksss deleted the string-gsub! branch March 22, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksss @soutaro