Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SEGV with parse negative position #1790

Merged
merged 1 commit into from Apr 6, 2024
Merged

Fix SEGV with parse negative position #1790

merged 1 commit into from Apr 6, 2024
+10 −0

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 5, 2024 •
edited

I've found the following cases. It will raise SEGV.

RBS::Parser.parse_type("a", range: -2...-1)

soutaro
soutaro approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.5 milestone Apr 6, 2024
@soutaro soutaro added this pull request to the merge queue Apr 6, 2024
Merged via the queue into ruby:master with commit 0b31458 Apr 6, 2024
17 checks passed
@ksss ksss deleted the parser-segv branch April 6, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksss @soutaro