Update File signatures #224

aikyo02 · 2020-03-15T14:24:36Z

I updated File signatures.

what I didn't do in this PR

I haven't written any tests for the following methods because they are not implemented in Linux.

File.birthtime
File#birthtime
File.lchmod

soutaro

Thanks, great! 👏 👍 🎉

aikyo02 force-pushed the update-file-signature branch 3 times, most recently from cab98f9 to 642f978 Compare March 29, 2020 15:45

aikyo02 added 26 commits April 8, 2020 16:46

bin/sort stdlib/builtin/file.rbs

d9edf27

rbs prototype runtime --merge File

37a8664

bin/annotate-with-rdoc stdlib/builtin/file.rbs

78401c0

Move _ToPath interface to builtin

1cb43f4

Update File.absolute_path signature

55ca7ca

Update File.absolute_path? signature

9d25c25

Update File.atime signature

147948a

Update File.basename signature

363fa0c

Update File.birthtime signature

ec77531

Update File.blockdev? signature

e257da5

Update File.chardev? signature

579fc9c

Update File.chmod signature

97c477f

Update File.chown signature

05a374e

Update File.ctime signature

ba36404

Update File.delete signature

0b934a4

Update File.directory? signature

a855580

Update File.dirname signature

272ef7e

Update File.empty? signature

4ee9f43

Update File.executable? signature

ff4d3b0

Update File.executable_real? signature

e2661d9

Update File.exist? signature

5f06f37

Make File.exists? into alias to File.exist?

7a74310

Update File.expand_path signature

cd50894

Update File.extname signature

37e4447

Update File.file? signature

13dae90

Update File.fnmatch signature

049c19a

aikyo02 force-pushed the update-file-signature branch from 3984feb to 85f8048 Compare April 8, 2020 07:47

aikyo02 added 25 commits April 9, 2020 19:27

Update File.umask signature

45eff1f

Update File.unlink signature

27c0c5e

Make File.delete into alias to File.unlink

f64faae

Update File.utime signature

52dcd1e

Update File.world_readable? signature

5fd8a28

Update File.world_writable? signature

509c773

Update File.writable? signature

fd39ac6

Update File.writable_real? signature

61658f4

Update File.zero? signature

de594e7

Make File.empty? into alias to File.zero?

a3a2efd

Add a test for File#atime

f2b06bf

Remove 💪👽🚨 from File#birthtime

35c5237

Update File#chmod signature

e417f63

Update File#chown signature

4d1197f

Add a test for File#ctime

3c40f11

Update File#flock signature

5c764b2

Update File#lstat signature

8a8798a

Update File#mtime signature

913661a

Update File#path signature

ba98111

Make File#to_path into alias to File#path

2dc1cde

Update File#size signature

2d1b62a

Update File#truncate signature

b2d1a09

Update initialize signature

e901e8a

Update File::ALT_SEPARATOR signature

f15bb70

Formatting

b0ef099

aikyo02 force-pushed the update-file-signature branch from 0b595af to b0ef099 Compare April 9, 2020 10:29

aikyo02 marked this pull request as ready for review April 9, 2020 17:36

soutaro approved these changes Apr 13, 2020

View reviewed changes

soutaro merged commit b485bb5 into ruby:master Apr 13, 2020

aikyo02 deleted the update-file-signature branch April 13, 2020 03:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update File signatures #224

Update File signatures #224

aikyo02 commented Mar 15, 2020 •

edited

soutaro left a comment

Update File signatures #224

Update File signatures #224

Conversation

aikyo02 commented Mar 15, 2020 • edited

what I didn't do in this PR

soutaro left a comment

Choose a reason for hiding this comment

aikyo02 commented Mar 15, 2020 •

edited