Fix warning #30

hanachin · 2019-10-16T13:11:12Z

I use following ruby.

% ruby -v
ruby 2.7.0dev (2019-10-16T12:00:36Z master f8fb51c976) [x86_64-darwin19]

I got warnings like following:

% bundle exec ruby -v bin/test_runner.rb 2>&1 | grep 'warning: '                 
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:321: warning: assigned but unused variable - pre_init
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:321: warning: assigned but unused variable - first_post
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:321: warning: assigned but unused variable - post_init
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2811: warning: mismatched indentations at 'end' with 'module' at 9
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2812: warning: mismatched indentations at 'end' with 'module' at 8
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:213: warning: `*' interpreted as argument prefix
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:227: warning: `*' interpreted as argument prefix
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:314: warning: `*' interpreted as argument prefix
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:315: warning: `*' interpreted as argument prefix
...../Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:196: warning: The last argument is used as the keyword parameter
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:196: warning: The last argument is used as the keyword parameter
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/test/hook.rb:196: warning: The last argument is used as the keyword parameter

after merging this pull request:

% bundle exec ruby -v bin/test_runner.rb 2>&1 | grep 'warning: '
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2811: warning: mismatched indentations at 'end' with 'module' at 9
/Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2812: warning: mismatched indentations at 'end' with 'module' at 8

soutaro · 2019-10-16T13:22:20Z

@hanachin Is the test result different between 2.6 and 2.7?

hanachin · 2019-10-16T13:29:04Z

@soutaro It looks so. I tried master branch HEAD bba1b27 with 2.6.3 and 2.7.0-dev, the result is below.

2.6.3

% git rev-parse HEAD
bba1b272395c4027603ba69c0224ed7fc5bee1a3
% ruby -v
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]
% bundle exec rake

# Running tests with run options --seed 27536:

..................................................................................................................D, [2019-10-16T22:25:47.134749 #11139] DEBUG -- : #foo receives arguments: []
D, [2019-10-16T22:25:47.134805 #11139] DEBUG -- : #foo receives block arguments: [123]
D, [2019-10-16T22:25:47.134823 #11139] DEBUG -- : #foo returns from block: 3
D, [2019-10-16T22:25:47.134835 #11139] DEBUG -- : #foo returns: "3"
E, [2019-10-16T22:25:47.134916 #11139] ERROR -- : [Foo#foo] ArgumentError: expected method type (::String x, ::Integer i, foo: 123 foo) { (Integer) -> Array[Integer] } -> ::String
E, [2019-10-16T22:25:47.134935 #11139] ERROR -- : [Foo#foo] BlockReturnTypeError: expected `Array[Integer]` but returns `3`
D, [2019-10-16T22:25:47.134953 #11139] DEBUG -- : #foo receives arguments: ["", 3, {:foo=>234}]
D, [2019-10-16T22:25:47.134968 #11139] DEBUG -- : #foo receives block arguments: [123]
D, [2019-10-16T22:25:47.134979 #11139] DEBUG -- : #foo returns from block: nil
D, [2019-10-16T22:25:47.134986 #11139] DEBUG -- : #foo returns: ""
E, [2019-10-16T22:25:47.135045 #11139] ERROR -- : [Foo#foo] ArgumentTypeError: expected `123` (foo) but given `234`
E, [2019-10-16T22:25:47.135059 #11139] ERROR -- : [Foo#foo] BlockReturnTypeError: expected `Array[Integer]` but returns `nil`
D, [2019-10-16T22:25:47.135068 #11139] DEBUG -- : #foo receives arguments: []
D, [2019-10-16T22:25:47.135078 #11139] DEBUG -- : #foo returns: :foo
E, [2019-10-16T22:25:47.135112 #11139] ERROR -- : [Foo#foo] ArgumentError: expected method type (::String x, ::Integer i, foo: 123 foo) { (Integer) -> Array[Integer] } -> ::String
E, [2019-10-16T22:25:47.135125 #11139] ERROR -- : [Foo#foo] ReturnTypeError: expected `::String` but returns `:foo`
E, [2019-10-16T22:25:47.135147 #11139] ERROR -- : [Foo#foo] MissingBlockError: required block is missing for `(::String x, ::Integer i, foo: 123 foo) { (Integer) -> Array[Integer] } -> ::String`
.D, [2019-10-16T22:25:47.138107 #11139] DEBUG -- : .open receives arguments: []
D, [2019-10-16T22:25:47.138422 #11139] DEBUG -- : .open receives block arguments: [#<#<Class:0x00007fca37d930b0>:0x00007fca37d9b698>]
D, [2019-10-16T22:25:47.138445 #11139] DEBUG -- : .open returns from block: 6
D, [2019-10-16T22:25:47.138698 #11139] DEBUG -- : .open returns: #<#<Class:0x00007fca37d930b0>:0x00007fca37d9b698>
E, [2019-10-16T22:25:47.138971 #11139] ERROR -- : [Foo.open] ReturnTypeError: expected `::String` but returns `#<#<Class:0x00007fca37d930b0>:0x00007fca37d9b698>`
E, [2019-10-16T22:25:47.139181 #11139] ERROR -- : [Foo.open] BlockArgumentTypeError: expected `::String` but given `#<#<Class:0x00007fca37d930b0>:0x00007fca37d9b698>`
.I, [2019-10-16T22:25:47.143138 #11139]  INFO -- : Installing hook on ::Foo#foo: (*any) -> ::String
I, [2019-10-16T22:25:47.143750 #11139]  INFO -- : Installing hook on ::Foo.open: () { (::String) -> void } -> ::Integer
I, [2019-10-16T22:25:47.143784 #11139]  INFO -- : Installing hook on ::Foo.new: () -> ::Foo
D, [2019-10-16T22:25:47.143806 #11139] DEBUG -- : .open receives arguments: []
D, [2019-10-16T22:25:47.143828 #11139] DEBUG -- : .new receives arguments: []
D, [2019-10-16T22:25:47.143844 #11139] DEBUG -- : .new returns: #<Foo:0x00007fca37e09648>
D, [2019-10-16T22:25:47.143875 #11139] DEBUG -- : .open receives block arguments: [""]
D, [2019-10-16T22:25:47.143890 #11139] DEBUG -- : #foo receives arguments: [1, 2, 3]
D, [2019-10-16T22:25:47.143902 #11139] DEBUG -- : #foo returns: "hello foo"
D, [2019-10-16T22:25:47.143925 #11139] DEBUG -- : .open returns from block: "hello foo"
D, [2019-10-16T22:25:47.143934 #11139] DEBUG -- : .open returns: 1
.

Finished tests in 11.731012s, 9.9736 tests/s, 70.8379 assertions/s.


117 tests, 831 assertions, 0 failures, 0 errors, 0 skips
Run options: --seed 57484

# Running:

.......

Finished in 0.001997s, 3505.2578 runs/s, 7010.5155 assertions/s.

7 runs, 14 assertions, 0 failures, 0 errors, 0 skips

master

% git rev-parse HEAD
bba1b272395c4027603ba69c0224ed7fc5bee1a3
% ruby -v
ruby 2.7.0dev (2019-10-16T12:00:36Z master f8fb51c976) [x86_64-darwin19]
% bundle exec rake

# Running tests with run options --seed 25745:

....EFEEEEEE.FFE.FF.E...........D, [2019-10-16T22:26:43.981743 #11223] DEBUG -- : .open receives arguments: []
D, [2019-10-16T22:26:43.981875 #11223] DEBUG -- : .open receives block arguments: [#<#<Class:0x00007f9ea7a0c088>:0x00007f9ea79fe898>]
D, [2019-10-16T22:26:43.981927 #11223] DEBUG -- : .open returns from block: 6
D, [2019-10-16T22:26:43.981962 #11223] DEBUG -- : .open returns: #<#<Class:0x00007f9ea7a0c088>:0x00007f9ea79fe898>
E, [2019-10-16T22:26:43.982130 #11223] ERROR -- : [Foo.open] ReturnTypeError: expected `::String` but returns `#<#<Class:0x00007f9ea7a0c088>:0x00007f9ea79fe898>`
E, [2019-10-16T22:26:43.982174 #11223] ERROR -- : [Foo.open] BlockArgumentTypeError: expected `::String` but given `#<#<Class:0x00007f9ea7a0c088>:0x00007f9ea79fe898>`
.D, [2019-10-16T22:26:43.989417 #11223] DEBUG -- : #foo receives arguments: []
D, [2019-10-16T22:26:43.989497 #11223] DEBUG -- : #foo receives block arguments: [123]
D, [2019-10-16T22:26:43.989536 #11223] DEBUG -- : #foo returns from block: 3
D, [2019-10-16T22:26:43.989567 #11223] DEBUG -- : #foo returns: "3"
E, [2019-10-16T22:26:43.989732 #11223] ERROR -- : [Foo#foo] ArgumentError: expected method type (::String x, ::Integer i, foo: 123 foo) { (Integer) -> Array[Integer] } -> ::String
E, [2019-10-16T22:26:43.989778 #11223] ERROR -- : [Foo#foo] BlockReturnTypeError: expected `Array[Integer]` but returns `3`
D, [2019-10-16T22:26:43.989823 #11223] DEBUG -- : #foo receives arguments: ["", 3, {:foo=>234}]
D, [2019-10-16T22:26:43.989891 #11223] DEBUG -- : #foo receives block arguments: [123]
D, [2019-10-16T22:26:43.989925 #11223] DEBUG -- : #foo returns from block: nil
D, [2019-10-16T22:26:43.989952 #11223] DEBUG -- : #foo returns: ""
E, [2019-10-16T22:26:43.990121 #11223] ERROR -- : [Foo#foo] ArgumentTypeError: expected `123` (foo) but given `234`
E, [2019-10-16T22:26:43.990163 #11223] ERROR -- : [Foo#foo] BlockReturnTypeError: expected `Array[Integer]` but returns `nil`
D, [2019-10-16T22:26:43.990193 #11223] DEBUG -- : #foo receives arguments: []
D, [2019-10-16T22:26:43.990224 #11223] DEBUG -- : #foo returns: :foo
E, [2019-10-16T22:26:43.990322 #11223] ERROR -- : [Foo#foo] ArgumentError: expected method type (::String x, ::Integer i, foo: 123 foo) { (Integer) -> Array[Integer] } -> ::String
E, [2019-10-16T22:26:43.990361 #11223] ERROR -- : [Foo#foo] ReturnTypeError: expected `::String` but returns `:foo`
E, [2019-10-16T22:26:43.990432 #11223] ERROR -- : [Foo#foo] MissingBlockError: required block is missing for `(::String x, ::Integer i, foo: 123 foo) { (Integer) -> Array[Integer] } -> ::String`
..I, [2019-10-16T22:26:44.006327 #11223]  INFO -- : Installing hook on ::Foo#foo: (*any) -> ::String
I, [2019-10-16T22:26:44.008209 #11223]  INFO -- : Installing hook on ::Foo.open: () { (::String) -> void } -> ::Integer
I, [2019-10-16T22:26:44.008272 #11223]  INFO -- : Installing hook on ::Foo.new: () -> ::Foo
D, [2019-10-16T22:26:44.008322 #11223] DEBUG -- : .open receives arguments: []
D, [2019-10-16T22:26:44.008386 #11223] DEBUG -- : .new receives arguments: []
D, [2019-10-16T22:26:44.008428 #11223] DEBUG -- : .new returns: #<Foo:0x00007f9ea624d208>
D, [2019-10-16T22:26:44.008499 #11223] DEBUG -- : .open receives block arguments: [""]
D, [2019-10-16T22:26:44.008539 #11223] DEBUG -- : #foo receives arguments: [1, 2, 3]
D, [2019-10-16T22:26:44.008595 #11223] DEBUG -- : #foo returns: "hello foo"
D, [2019-10-16T22:26:44.008665 #11223] DEBUG -- : .open returns from block: "hello foo"
D, [2019-10-16T22:26:44.008694 #11223] DEBUG -- : .open returns: 1
..................................................................................

Finished tests in 35.765481s, 3.2713 tests/s, 23.0110 assertions/s.


Error:
Ruby::Signature::RbiScaffoldTest#test_constant:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:220:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:114:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:79:in `push_module'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:113:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:113:in `test_constant'

Failure:
Ruby::Signature::RbiScaffoldTest#test_alias [/Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:137]
Minitest::Assertion: --- expected
+++ actual
@@ -1,5 +1,5 @@
 "module Foo
-  alias foo Bar
+  alias  
 
   alias hello world
 end

Error:
Ruby::Signature::RbiScaffoldTest#test_comment:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:352:in `test_comment'

Error:
Ruby::Signature::RbiScaffoldTest#test_tuple:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:214:in `test_tuple'

Error:
Ruby::Signature::RbiScaffoldTest#test_basic_object:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:318:in `test_basic_object'

Error:
Ruby::Signature::RbiScaffoldTest#test_1:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:31:in `test_1'

Error:
Ruby::Signature::RbiScaffoldTest#test_class_of:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:280:in `test_class_of'

Error:
Ruby::Signature::RbiScaffoldTest#test_block_args:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:162:in `test_block_args'

Failure:
Ruby::Signature::RbiScaffoldTest#test_all [/Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:248]
Minitest::Assertion: --- expected
+++ actual
@@ -1,4 +1,4 @@
 "class File
-  def self.split: (String & Integer file) -> void
+  def self.split: (any file) -> void
 end
 "

Failure:
Ruby::Signature::RbiScaffoldTest#test_non_parameter_type_member [/Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:405]
Minitest::Assertion: --- expected
+++ actual
@@ -1,4 +1,3 @@
-"class Dir
-  include Enumerable
+"class Dir[Elem]
 end
 "

Error:
Ruby::Signature::RbiScaffoldTest#test_noreturn:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:168:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:258:in `test_noreturn'

Failure:
Ruby::Signature::RbiScaffoldTest#test_overloading [/Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:201]
Minitest::Assertion: --- expected
+++ actual
@@ -1,7 +1,7 @@
 "class Class
   def initialize: () -> void
-                | (?Class superclass) -> void
-                | () { (Class arg0) -> any } -> void
-                | (?Class superclass) { (Class arg0) -> any } -> void
+                | () -> void
+                | () -> void
+                | () -> void
 end
 "

Failure:
Ruby::Signature::RbiScaffoldTest#test_parameter [/Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:308]
Minitest::Assertion: --- expected
+++ actual
@@ -1,4 +1,3 @@
 "class Array[Elem]
-  include Enumerable
 end
 "

Error:
Ruby::Signature::RbiScaffoldTest#test_bool:
NoMethodError: undefined method `type' for nil:NilClass
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:420:in `type_of0'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:406:in `type_of'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:276:in `method_type'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `map'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:188:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:109:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:61:in `push_class'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:108:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:242:in `block in process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:546:in `block in each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:544:in `each_child'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:241:in `process'
    /Users/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/scaffold/rbi.rb:35:in `parse'
    /Users/sei/src/github.com/ruby/ruby-signature/test/ruby/signature/rbi_scaffold_test.rb:335:in `test_bool'

117 tests, 823 assertions, 5 failures, 9 errors, 0 skips

hanachin · 2019-10-16T23:27:16Z

I updated the code, CI passed, ready for review.

% RUBYOPT="-w" bundle exec rake 2>&1 | grep 'warning:'
/home/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2810: warning: mismatched indentations at 'end' with 'module' at 9
/home/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2811: warning: mismatched indentations at 'end' with 'module' at 8
/home/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2810: warning: mismatched indentations at 'end' with 'module' at 9
/home/sei/src/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb:2811: warning: mismatched indentations at 'end' with 'module' at 8

hanachin added 3 commits October 17, 2019 08:10

Fix warning: `*' interpreted as argument prefix

8ef6952

Fix warning: assigned but unused variable

87a9821

warning: possibly useless use of + in void context

00ab73f

hanachin force-pushed the fix_warning branch from b3154b4 to 00ab73f Compare October 16, 2019 23:10

hanachin mentioned this pull request Oct 16, 2019

ruby-head builds fail #33

Closed

Update rake ~> 10.0 -> ~> 13.0 to reduce warning

0ba8a04

soutaro merged commit 76b434c into ruby:master Oct 16, 2019

hanachin deleted the fix_warning branch December 29, 2019 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix warning #30

Fix warning #30

hanachin commented Oct 16, 2019

soutaro commented Oct 16, 2019

hanachin commented Oct 16, 2019 •

edited

hanachin commented Oct 16, 2019

Fix warning #30

Fix warning #30

Conversation

hanachin commented Oct 16, 2019

soutaro commented Oct 16, 2019

hanachin commented Oct 16, 2019 • edited

2.6.3

master

hanachin commented Oct 16, 2019

hanachin commented Oct 16, 2019 •

edited