Update fiber.rbs #378
Closed
Update fiber.rbs #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dearest Reviewer, I was parsing this file and found this typo. I believe these strings need to be capitalized. If I am incorrect please close this pull request. Once again thank you for your work and time. Dictated but not reviewed, Becker
|
After reading this commit I see I am incorrect. 565eb55#diff-688758104ef6487758a411339b13bdbcR27 https://github.com/ruby/rbs/blob/master/docs/syntax.md#type-alias-declaration I did not understand the gravity of this statement. These alias types to be used in the rbs system directly. I am closing this. I wish it was more obvious that these are type alias like it has to start with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dearest Reviewer,
I was parsing this file and found this typo. I believe these strings need to be capitalized. If I am incorrect please close this pull request.
Once again thank you for your work and time.
Dictated but not reviewed,
Becker