Support singleton attr by prototype rb #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
commented
Dec 6, 2020
| @@ -15,6 +15,14 @@ def method_kind | |||
| :instance | |||
| end | |||
| end | |||
|
|
|||
| def attribute_kind | |||
There was a problem hiding this comment.
Lines 205 to 207 in 8871f6d
Attribute doesn't support
singleton_instance syntax (self?), unlike method definition. Is it intentional?
There was a problem hiding this comment.
It's intentional but I'm open to adding the syntax if it's better.
I was assuming that we rarely define attributes for both singleton and instance while the presence of module_function implies it happens frequently fordefs.
There was a problem hiding this comment.
I was assuming that we rarely define attributes for both singleton and instance while the presence of module_function implies it happens frequently for
defs.
I completely agree. It is rare and I do not have any use cases for singleton_instance attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds to support singleton attr, which was introduced by #502, to
rbs prototype rbcommand.