Use relative path for Gem::Specification#files #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It cannot be installed with Ruby master.
$ ruby -v ruby 2.7.0dev (2019-10-30T15:38:16Z master 5f8795a07b) [x86_64-linux] $ gem install pkg/ruby-signature-0.1.0.gem ERROR: While executing gem ... (Gem::Package::PathError) installing into parent path /home/pocke/ghq/github.com/ruby/ruby-signature/lib/ruby/signature/parser.rb of /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/ruby-signature-0.1.0 is not allowedI guess the cause is this commit of rubygems. rubygems/rubygems@e2b5c58
It makes symlink checking restrict, and the check disallows the absolute path.
Solution
Use a relative path instead of the absolute path.
I'm not sure it is a rubygems's matter, or not.
But absolute path is meaningless for Gem::Specification#files. So I think this change is meaningful even if rubygems is fixed.
Thanks! @hanachin