Declare supported ruby versions of rbs #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR provides a patch to declare ruby versions supported by rbs.
koic
reviewed
Jan 16, 2021
| @@ -34,4 +34,5 @@ Gem::Specification.new do |spec| | |||
| spec.bindir = "exe" | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
| spec.require_paths = ["lib"] | |||
| spec.required_ruby_version = ">= 2.6" | |||
There was a problem hiding this comment.
I'm concerned that it is inconsistent with TargetRubyVersion of .rubocop.yml. It's better to be consistent with minimum version of Ruby (2.6? or 2.7?) that RBS supports.
There was a problem hiding this comment.
Hmm. What does TargetRubyVersion mean for Rubycw/Rubycw? @pocke
There was a problem hiding this comment.
TargetRubyVersion does not affect Rubycw/Rubycw cop. The cop uses RubyVM::AST to detect warnings, so it depends on the runtime Ruby version. If RuboCop runs on Ruby 2.6, the cop checks codes as Ruby 2.6.
But I think it is a good idea to make TargetRubyVersion and required_ruby_version the same.
It is the best practice of RuboCop and it avoids confusion like this thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a patch to declare ruby versions supported by rbs.