Add features for partial invalidation #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
commented
Feb 24, 2021
|
|
||
| def initialize: (env: Environment) -> void | ||
|
|
||
| def only_ancestors!: (?bool only) -> self |
There was a problem hiding this comment.
[Goodcheck] Prefer
boolishoverboolfor method arguments and block return values (view)See the doc below:
https://github.com/ruby/rbs/blob/78d04a2db0f1c4925d2b13c2939868edf9465d6c/docs/syntax.md#bool-or-boolish
Rule rbs.prefer_boolishYou can close this issue if no need to fix it. Learn more.
I closed this issue, because:
- When you strictly want
true | false.
soutaro
force-pushed
the
invalidation
branch
from
ce92abd
to
c41cbb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalidating all of the caches -- definition builder cache, method builder cache, and ancestor cache -- makes interactive RBS access really slow. This pull request adds some features to implement partial cache invalidation.
AncestorGraphcalculates descendant classes/modules/interfaces of a class/module/interface, that allows identifying a set of types to be invalidated.Environment#rejectallows removing declarations from environments.