New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix global_variables.rbs #753

Merged

soutaro merged 2 commits into ruby:master from pocke:Fix_global_variables_documentation

Aug 19, 2021

Member

pocke commented Aug 18, 2021

This PR contains two fixes to global_variables.rbs, which is introduced in #749.

Fix $-i type, it stores String or a nil
Fix $0 and $PROGRAM_NAME document.
- I brought the doc from https://github.com/ruby/ruby/blob/95aff214687a5e12c3eb57d056665741e734c188/doc/globals.rdoc

pocke added 2 commits

August 19, 2021 01:43


          Fix $-i type

227a90b

It is not `bool` but an optional String


          Fix global variables documentation

b99114a

`$0` stores the program name, but the doc is for `$@`

Collaborator

ksss commented Aug 19, 2021

Thanks ✨

soutaro merged commit 8c30d80 into ruby:master

pocke deleted the Fix_global_variables_documentation branch

August 19, 2021 02:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment