[io/wait] Add RBS for "io/wait" #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like RDoc is out of date. JA version of the doc says it returns |
|
I'm not sure if we can implement a stable test case for the methods... |
HoneyryderChuck
force-pushed
the
io-wait
branch
2 times, most recently
from
b4cb913
to
46b7b36
Compare
|
I "bent" the rules a bit to make the tests pass in all rubies. Seems that the behaviour changed 🤷 . Would it be possible to "pass the ball" to ruby core to fix the return value of these methods, and then rely on rbs test cases to keep it from drifting again? I'm not sure if we can do better here. |
HoneyryderChuck
force-pushed
the
io-wait
branch
from
46b7b36
to
8d44812
Compare
Picking up the work left in ruby#563. The most controversial part is the mismatch between what documentation says about return types and what actually gets returned (doc says bool, but IO or nil are actually returned).
HoneyryderChuck
force-pushed
the
io-wait
branch
from
8d44812
to
bf8af14
Compare
soutaro
approved these changes
Aug 21, 2021
This was referenced Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up the work left in #563.
The most controversial part is the mismatch between what documentation
says about return types and what actually gets returned (doc says bool,
but IO or nil are actually returned).