Use "untyped" as an exceptation of return value of IO#ready? #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 2.7, the method returns true|false. In Ruby 3.0, it returns nil|IO. Now in Ruby 3.1.0-dev, it returns true|false again. The CI of ruby/ruby repository now fails due to the type test of the method, so I'd like to disable the test tentatively.
mame
added a commit
to mame/ruby
that referenced
this pull request
Nov 17, 2021
To prevent the CI failure due to the change of io-wait ruby/rbs#828
mame
added a commit
to ruby/ruby
that referenced
this pull request
Nov 17, 2021
To prevent the CI failure due to the change of io-wait ruby/rbs#828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 2.7, the method returns true|false.
In Ruby 3.0, it returns nil|IO.
Now in Ruby 3.1.0-dev, it returns true|false again.
The CI of ruby/ruby repository now fails due to the type test of the
method, so I'd like to disable the test tentatively.