Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "untyped" as an exceptation of return value of IO#ready? #828

Merged
merged 1 commit into from
Nov 17, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/stdlib/IO_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,11 @@ class IOWaitTest < Test::Unit::TestCase

def test_readyp
if_ruby3 do
# This method returns true|false in Ruby 2.7, nil|IO in 3.0, and true|false in 3.1.

IO.pipe.tap do |r, w|
assert_send_type(
"() -> nil",
"() -> untyped",
r, :ready?
)
end
Expand All @@ -263,7 +265,7 @@ def test_readyp
w.write("hello")

assert_send_type(
"() -> IO",
"() -> untyped",
r, :ready?
)
end
Expand Down