Strict include/delete element types #835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBS has provided a method type of
include?
/delete
withuntyped
.This is more compatible with Ruby runtime behavior.
I have found that limiting the type of argument here makes more sense to find possible bugs, and want to change the type.
This is an example of the type error:
Parser::KEYWORDS
isHash[String, bot]
, and passing a Symbol toinclude?
always returnsfalse
, which is not what I want to do here.