Set the store attribute for newly created modules #614
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A regression has been introduced between RDoc 6.0.1 and 6.0.2 with ef958c2 where a new
RDoc::NormalModule
instance is created without a store associated to it.This produces an error on generation through SDoc (see zzak/sdoc#124).
I don't know how to reproduce this through the test suite but here are some steps to reproduce it locally:
Then put the following content in a Rakefile:
Make sure to have
sdoc
installed or in your Gemfile and then runrake rdoc
. This error isn't reproducible without using SDoc ; the culprit line is here which reaches this one and produces the error:This issue is pretty weird because parse order actually matters since the nested constant must be referenced before the top level constant definition (i.e.
bar.rb
must be parsed beforefoo.rb
). Dunno whether the fix is correct or not but it works. 🤷♂️Have a nice day !