Skip to content

Commit

Permalink
Cyrillic chars are now forced to be displayed in full-width on Windows
Browse files Browse the repository at this point in the history
So testing is no longer necessary.
  • Loading branch information
aycabta committed Oct 3, 2021
1 parent df2a1b4 commit c595895
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions test/reline/yamatanooroti/test_rendering.rb
Original file line number Diff line number Diff line change
Expand Up @@ -752,28 +752,6 @@ def test_force_enter
EOC
end

def test_cyrillic_chars
omit unless Reline::IOGate.win?
start_terminal(50, 50, %W{ruby -I#{@pwd}/lib #{@pwd}/test/reline/yamatanooroti/multiline_repl}, startup_message: 'Multiline REPL.')
write("`chcp 850`\n")
write("`chcp`\n")
write("def гопота; 3; end\n")
write("гопота\n")
close
assert_screen(<<~'EOC')
Multiline REPL.
prompt> `chcp 850`
=> "Active code page: 850\n"
prompt> `chcp`
=> "Active code page: 850\n"
prompt> def гопота; 3; end
=> :гопота
prompt> гопота
=> 3
prompt>
EOC
end

def test_with_newline
omit if Reline::IOGate.win?
cmd = %Q{ruby -e 'print(%Q{abc def \\e\\r})' | ruby -I#{@pwd}/lib -rreline -e 'p Reline.readline(%{> })'}
Expand Down

1 comment on commit c595895

@duerst
Copy link
Member

@duerst duerst commented on c595895 Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may work well in Japan, where Shift_JIS based fonts have full-width Cyrillic characters. But virtually nobody in Japan really cares about Cyrillic. On the other hand, in Eastern Europe, where Cyrillic is used widely, full-width (i.e. double-width) Cyrillic characters will be very inconvenient. Ideally, Cyrillic characters should be single-width (half-width) for much greater overall user satisfaction.

Please sign in to comment.