Rename dialog_pointer_* to dialog_highlight_*

[st0012]

"Pointer" is not what we usually use to describe a selected item.

"Highlight" is a more common word for the scenario so we should use it instead.

[st0012]

@peterzhu2118 @nobu Wdyt?

[peterzhu2118]

I don't really have a strong opinion on whether it should be called "pointer" or "highlight". Both terms make sense to me, "pointer" means the element that is pointed to, and "highlight" means the element that is highlighted, so I think either term makes sense.

[st0012]

Is it common to say a keyboard selected item "pointed"? I'd expect "pointed" to be cursor-related (which doesn't seem to work on reline's dialog). But maybe it's because of my limited English 😬

I'm fine with "pointer" in the context of reline. But I was trying to make a related PR in irb, which will expose these APIs to all Ruby users. And I think highlight will be clearer to most users compared to pointer. I can of course just name things in irb differently but I want to avoid that.

[peterzhu2118]

I agree that "pointer" makes more sense in the context of a GUI with a mouse. 👍 I'm in favor of this PR.

[mame]

I don't know much about reline but this is not just an internal name, but a name used in the configuration file, right? If so it's incompatible?

[st0012]

These apis/configs were newly added and haven’t been released yet

[mame]

Oh I see. Thank you for the explanation.