Ignore unhandled escape sequences #522
Conversation
| input[idx] ? [:matched, idx + 1] : [:matching, nil] | ||
| when 79 # == 'O'.ord | ||
| # SS3 sequence | ||
| input[idx + 1] ? [:matched, idx + 2] : [:matching, nil] |
There was a problem hiding this comment.
F1, F2, F3, F4 key in macOS ["\eOP", "\eOQ", "\eOR", "\eOS"]
There are many other type of escape sequence, but I think it's CSI and SS3 is enough for keyboard input sequence. some other sequence ends with "\a" or "\e\\" (example: "\e]0;NewWindowTitle\e\\") but if we implement it and user mistakenly input ESC+], irb looks hanging up.
tompng
force-pushed
the
ignore_unhandled_escape_sequences
branch
from
ed9a5cc
to
bf643a1
Compare
|
Not sure if y'all are looking for testers, but I can confirm that this fixes the F1, F2, F3, etc. keys to no longer spew out escape codes in an "xterm-256color" terminal on Debian Linux. |
tompng
force-pushed
the
ignore_unhandled_escape_sequences
branch
from
bf643a1
to
732d3a9
Compare
| method_symbol = @config.editing_mode.get_method(key.char) | ||
| process_key(key.char, method_symbol) | ||
| if @config.editing_mode_is?(:vi_command) || @config.editing_mode_is?(:vi_insert) | ||
| # split ESC + key in vi mode |
There was a problem hiding this comment.
This is only used in vi mode.
In emacs mode, this is making ESC+char inserted into input buffer
| @@ -3345,4 +3347,7 @@ def finish | |||
| @mark_pointer = new_pointer | |||
| end | |||
| alias_method :exchange_point_and_mark, :em_exchange_mark | |||
|
|
|||
| private def em_meta_next(key) | |||
| end | |||
There was a problem hiding this comment.
In method process_key, ed_insert is called if method_symbol is not defined.
I think adding this method is the simplest and easiest way to prevent ESC insertion.
Although, not all method_symbol written in lib/reline/key_actor/emacs.rb is defined in line_aditor.rb and I think it is not causing problem. Perhaps there is another way to fix without defining this method.
tompng
force-pushed
the
ignore_unhandled_escape_sequences
branch
from
732d3a9
to
2c7188c
Compare
tompng
force-pushed
the
ignore_unhandled_escape_sequences
branch
from
2c7188c
to
09fcf0a
Compare
(ruby/reline#522) * Add unassigned escape sequence matcher to KeyStroke * Do not insert ESC and unassigned ESC+key to input buffer
Fixes #514
When unknown escape sequence is typed, reline prints the escape sequence.
In Mac Terminal.app, the keys are F1~F12 keys, option+A, option+up, etc.
This pull request will change reline to correctly ignore unmatched CSI sequence, SS3 sequence, ESC+char and single ESC input.