Refactor Reline::Core #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
approved these changes
Jul 4, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 4, 2023
(ruby/reline#561) * Use Reline::Core.encoding instead of directly referencing IOGate * Set input/output based on the IOGate's interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reline::Corealready hasencodingmethod, we don't need to get encoding fromIOGaterepeatedly.IOGateclasses have different input/output setters, we can use that instead of checking theIOGate's class type.