Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing close to test_rendering.rb #573

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add missing close to test_rendering.rb #573

merged 1 commit into from
Jul 18, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Jul 18, 2023

Without close, process ruby -I#{@pwd}/lib #{@pwd}/test/reline/yamatanooroti/multiline_repl} will remain until every test ends.

% grep -c "close" test/reline/yamatanooroti/test_rendering.rb 
96 → 99
% grep -c "assert_screen" test/reline/yamatanooroti/test_rendering.rb
99
% grep -c "def test_" test/reline/yamatanooroti/test_rendering.rb              
99

@tompng tompng merged commit 7cd8170 into ruby:master Jul 18, 2023
30 checks passed
@tompng tompng deleted the add_test_rendering_missing_close branch July 18, 2023 20:31
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 18, 2023
@tompng @matzbot
[ruby/reline] Add missing close to test_rendering.rb
b400307 
(ruby/reline#573)

ruby/reline@7cd817036e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tompng @st0012