Add mode_string to prompt calculation dependencies #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ima1zumi
force-pushed
the
prompt_mode_string_deps
branch
from
64bdb66
to
6ff16f7
Compare
|
Can we add |
|
Modified the existing test. The test will fail in master branch with: <"(ins)prompt> :a\n" +
"=> :a\n" +
"(ins)prompt> :a\n" +
"=> :a\n" +
"(cmd)prompt> :a\n"> expected but was
<"(ins)prompt> :a\n" +
"=> :a\n" +
"(cmd)prompt> :a\n" +
"=> :a\n" +
"(ins)prompt> :a\n"> |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Mar 24, 2024
(ruby/reline#658) * Add mode_string to prompt calculation dependencies * Update vi show-mode-in-prompt test ruby/reline@a0cee06ec5
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
(ruby/reline#658) * Add mode_string to prompt calculation dependencies * Update vi show-mode-in-prompt test ruby/reline@a0cee06ec5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show-mode-in-promptwas broken in v0.5.0.pre.1Fixes it by adding prompt_mode to prompt list calculation dependencies.
To enable
show-mode-in-prompt, add this to.inputrc