Always call finalize and deprep #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
Merged
st0012
reviewed
Apr 4, 2024
lib/reline.rb
Outdated
| @@ -366,18 +366,14 @@ def readline(prompt = '', add_hist = false) | |||
| rescue Errno::EIO | |||
| # Maybe the I/O has been closed. | |||
| rescue StandardError => e | |||
There was a problem hiding this comment.
Do we still need to rescue StandardError separately after this?
There was a problem hiding this comment.
Nice catch 👍
No need. updated
Also removed rescue Exception which is added in #404, looks like only to run finalize and deprep
st0012
approved these changes
Apr 4, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 5, 2024
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use ensure to ensure
finalizeanddeprepalways called.If we don't use ensure, these cleanup can be skipped if
->{return}.callorthrowis used.This seems to reduce SystemStackError of #667
But does not solve it.
ruby -Ilib -rreline -e "Thread.new{p Reline.readline'>'};sleep 0.1; p Reline.readline'>'still raise SystemStackError