Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inputrc nested $if $else $endif bug #689

Merged
merged 1 commit into from Apr 25, 2024
Merged

Fix inputrc nested $if $else $endif bug #689

merged 1 commit into from Apr 25, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Apr 25, 2024

Reading inputrc had a bug like this

$if Ruby
$else
$endif

# Everything below is skipped
set editing-mode vi

Although the above example is not a nested $if, this is caused by nested $if bug.
This pull request fixes it, and add nested $if tests.

@tompng tompng added the bug Something isn't working label Apr 25, 2024
ima1zumi
ima1zumi approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ima1zumi ima1zumi merged commit 0d8aea2 into ruby:master Apr 25, 2024
40 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Apr 25, 2024
@tompng @matzbot
[ruby/reline] Fix inputrc nested $if $else $endif bug
4ff2493 
(ruby/reline#689)

ruby/reline@0d8aea26ec
@tompng tompng deleted the inputrc_if_else_endif_fix branch April 25, 2024 16:50
artur-intech pushed a commit to artur-intech/ruby that referenced this pull request Apr 26, 2024
@tompng @artur-intech
[ruby/reline] Fix inputrc nested $if $else $endif bug
ada6c3b 
(ruby/reline#689)

ruby/reline@0d8aea26ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tompng @ima1zumi