Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include private_constant-ed module #155

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Jun 22, 2024

Included constants are not private. So private constants in private module aren't private.

See also: #154 (comment)

@kou kou changed the title Fix private_constant being public Don't include private_constant-ed module Jun 22, 2024
@kou kou merged commit cfa8dd9 into ruby:master Jun 22, 2024
61 checks passed
@kou
Copy link
Member

kou commented Jun 22, 2024

Thanks.

@naitoh naitoh deleted the fix_private_constant branch June 22, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants