Fix String#encode's fallback option, it should accept an object which has [] method
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
String#encodeaccepts an object which has[]method as a fallback, but the type definition does not accept it.Solution
Update the type of
fallbackoption to accept it.And I'd like to use the type for
Pathname#binwritebecause it accepts keyword arguments ofString#encode. So I exposeString::encode_fallbackas a type alias.Note
Note that actually an object with
[]method does not work as a fallback in Ruby 2.7.0.I reported the problem to bugs.ruby-lang.org, and it has been fixed.
https://bugs.ruby-lang.org/issues/16649
I concerned the stdlib test raises an error, but it works well. Because the fallback option is passed but it is not used.