Skip to content

Commit

Permalink
Fix Rinda test teardown for omitted tests
Browse files Browse the repository at this point in the history
New test failures on MINGW appeared after
c2e37c8.

      1) Error:
    Rinda::TupleSpaceProxyTest#test_00_template:
    NoMethodError: undefined method `stop_service' for nil:NilClass
        D:/a/ruby/ruby/src/test/rinda/test_rinda.rb:516:in `teardown'

      2) Error:
    Rinda::TupleSpaceProxyTest#test_ruby_talk_264062:
    NoMethodError: undefined method `stop_service' for nil:NilClass
        D:/a/ruby/ruby/src/test/rinda/test_rinda.rb:516:in `teardown'

Teardown happens even when the test is omitted.

See: https://github.com/ruby/ruby/runs/7058984522
  • Loading branch information
XrXr committed Jun 26, 2022
1 parent d3d5ef0 commit 49d5921
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test/rinda/test_rinda.rb
Expand Up @@ -497,6 +497,7 @@ class TupleSpaceProxyTest < Test::Unit::TestCase

def setup
if RUBY_PLATFORM.match?(/mingw/) && ENV['MSYSTEM'] == 'UCRT64'
@omitted = true
omit 'This test seems to randomly hang on GitHub Actions MinGW UCRT64'
end
super
Expand All @@ -506,6 +507,9 @@ def setup
@server = DRb.start_service("druby://localhost:0")
end
def teardown
return if @omitted
@omitted = false

# implementation-dependent
@ts_base.instance_eval{
if th = @keeper
Expand Down

0 comments on commit 49d5921

Please sign in to comment.