YJIT: Inline simple getlocal+leave iseqs #10360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
force-pushed
the
yjit-inline-identity
branch
from
646a6f2
to
d322d8b
Compare
k0kubun
reviewed
Mar 25, 2024
k0kubun
reviewed
Mar 25, 2024
k0kubun
reviewed
Mar 25, 2024
| @@ -6774,6 +6779,17 @@ fn iseq_get_return_value(iseq: IseqPtr, captured_opnd: Option<Opnd>) -> Option<I | |||
| return None; | |||
| } | |||
| match first_insn { | |||
| YARVINSN_getlocal_WC_0 => { | |||
| // Only accept simple positional only cases for both the caller and the callee. | |||
| // Reject block ISEQs to avoid autosplat and other block parameter complications. | |||
There was a problem hiding this comment.
Rejecting the captured_opnd.is_some() case only impacts yield. Is this not a problem for block.call?
There was a problem hiding this comment.
It is a problem for block.call, but we essentially do a manual fallback with rb_optimized_call() for those cases 😅 All the block setup code check captured_opnd .
k0kubun
approved these changes
Mar 25, 2024
maximecb
approved these changes
Mar 25, 2024
I think possibly you mean def self.let(x, type)
x
endanyways, neat PR! |
This mainly targets things like `T.unsafe()` from Sorbet, which is just an identity function at runtime and only a hint for the static checker. Only deal with simple caller and callees (no keywords and splat etc.). Co-authored-by: Takashi Kokubun (k0kubun) <takashikkbn@gmail.com>
XrXr
force-pushed
the
yjit-inline-identity
branch
from
d322d8b
to
57219b5
Compare
We do yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly targets things like
T.let()from Sorbet, which is just anidentity function at runtime and only a hint for the static checker.
Only deal with simple caller and callees (no keywords and splat etc.).