Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rb_grantpt function #10452

Merged
merged 1 commit into from Apr 4, 2024
Merged

Remove rb_grantpt function #10452

merged 1 commit into from Apr 4, 2024

Conversation

nobu
Copy link
Member

@nobu nobu commented Apr 4, 2024 •
edited

This function is only for pty library, and It does nothing other than just call grantpt(3) since #7527.

@nobu
Revert "hijack SIGCHLD handler for internal use"
3ac6a03 
This reverts commit 054a412.
SIGCHLD `waidpid`, `waitpid_lock` and related code, have been removed
at ruby#7527.
@nobu nobu changed the title Revert "hijack SIGCHLD handler for internal use" Remove rb_grantpt function Apr 4, 2024
@matzbot matzbot merged commit 3ac6a03 into ruby:master Apr 4, 2024
100 checks passed
@nobu nobu deleted the remove-rb_grantpt branch April 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@nobu @matzbot