YJIT: Fix reference update for Invariants::no_ep_escape_iseqs
#10656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the update was done in the ISEQ callback. That effectively never updated anything because the callback itself is given an intact reference, so it could update its content, and `rb_gc_location(iseq)` never returned a new address. Update the whole table once in the YJIT root instead.
Because of the way things are sequenced, it doesn't work properly during auto-compaction.
Even though unused, it's supposed to take a pointer like the C side expects.
k0kubun
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invariants::no_ep_escape_iseqsThe nil-on-stack issue on CI was still reproducible locally by running
make test-all TESTS='-j1 ../test/ruby/test_enumerator.rb' RUN_OPTS='--yjit-call-threshold=1 --yjit-verify-ctx'in a loop locally. After apply this changeset the crash seem to have gone away.