Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements for Ruby core [ci skip] #2612

Merged
merged 1 commit into from Oct 26, 2019

Conversation

zverok
Copy link
Contributor

@zverok zverok commented Oct 25, 2019

This PR contains several improvements for Ruby core language/core classes docs (I can split it in several, if it is necessary). In particular:

  • Mention of top-level return in keywords.rdoc;
  • Documentation for comments syntax, which was completely missing (?) previously;
  • Documentation of rescue inside blocks in exceptioins.rdoc;
  • Enhance Object#to_enum docs with more explanation and examples;
  • Make chomp: option more obvious for String#each_line and #lines (previously this only option, to be discovered, required reader to travel through links and read deep into other classes documentation);
  • Enhance Proc#>> and #<< docs with explanations about arguments;
  • Enhance Process general docs with some explanation of module's goals.

Probably language should be checked (I am not native).

* Top-level `return`;
* Documentation for comments syntax;
* `rescue` inside blocks;
* Enhance `Object#to_enum` docs;
* Make `chomp:` option more obvious for `String#each_line` and
  `#lines`;
* Enhance `Proc#>>` and `#<<` docs;
* Enhance `Processs` class docs.
@nobu
Copy link
Member

nobu commented Oct 26, 2019

It might be better to split into separate commits per items.

@nobu nobu merged commit bddb31b into ruby:master Oct 26, 2019
@zverok zverok deleted the update-core-docs branch October 26, 2019 06:03
zverok added a commit to zverok/ruby that referenced this pull request Dec 22, 2019
In ruby#2612 I made two typos (extra ,, and copy-pasted
same line of code instead of showing two different
ones), fixing them.
nobu pushed a commit that referenced this pull request Dec 22, 2019
In #2612 I made two typos (extra ,, and copy-pasted
same line of code instead of showing two different
ones), fixing them.
@zverok zverok added the Documentation Improvements to documentation. label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
2 participants